[Webkit-unassigned] [Bug 209465] [Curl] Proxy setting API does not work until Network process starts.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 1 20:26:43 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=209465

--- Comment #12 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #6)
> Comment on attachment 394356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394356&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [Curl] Proxy setting API does not working until Network process starts.
> 
> working → work
> Remove the period. Let's follow the majority style.
> This sentence doesn't make send to me. Do you mean "Proxy setting API does
> not work if Network process isn't started"?

Fixed.

> 
> > Tools/TestWebKitAPI/Tests/WebKit/curl/HTTPServer.cpp:40
> > +    auto& endpoint = Inspector::RemoteInspectorSocketEndpoint::singleton();
> 
> I don't think it's a good idea to use
> Inspector::RemoteInspectorSocketEndpoint here.
> Why don't you use Tools/TestWebKitAPI/TCPServer.cpp?
> 
> > Tools/TestWebKitAPI/Tests/WebKit/curl/HTTPServer.h:69
> > +class HTTPServer final : public RemoteInspectorSocketEndpoint::Listener {
> 
> Do you know there is already TestWebKitAPI::HTTPServer class in
> Tools/TestWebKitAPI/cocoa/HTTPServer.mm?

We chose RemoteInspectorSocketEndpoint because it is working on wincairo.
If we use TCPServer, we have to implement some for wincairo.
RemoteInspectorSocketEndpoint is not generic name, but its implementation seems to be for generic server connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200402/816eba20/attachment-0001.htm>


More information about the webkit-unassigned mailing list