[Webkit-unassigned] [Bug 209579] Escaped UTF-8 not parsed correctly with icu 52

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209579

--- Comment #14 from Mike Gorse <mgorse at suse.com> ---
(In reply to Michael Catanzaro from comment #11)
> (In reply to Mike Gorse from comment #0)
> > Anyhow, prior to icu 53, U8_COUNT_TRAIL_BYTES does not cast its parameter to
> > unsigned before doing comparisons, and it ends up always returning 0 if a
> > signed char is passed in.
> 
> Oh, *wow*, so this is a runtime failure, not a build failure?
> 
> I didn't look closely enough at first and assumed it was a build failure.
> Since this is a runtime failure, and distributors updating WebKit will not
> see any build error, that seems like a pretty strong argument to take the
> patch; otherwise, we'll just wind up with broken behavior at runtime. Is
> there some example HTML that demonstrates the incorrect behavior?

Yes, it is a runtime failure. I don't have a sample off-hand. I noticed it when I tried to smoke test my WebKitGTK package and found that I couldn't authenticate a gmail connection in evolution; clicking Next on the screen that asked for an email address wouldn't move to the next screen for me to enter a password. JavaScriptCore appears to encounter %e2 somewhere on the page and fail to recognize it as the beginning of a UTF-8 sequence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200401/af0f68ff/attachment.htm>