[Webkit-unassigned] [Bug 209579] Escaped UTF-8 not parsed correctly with icu 52

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209579

--- Comment #10 from Michael Catanzaro <mcatanzaro at gnome.org> ---
So our dependencies policy [1] allows us to require ICU 60 (the version available in Ubuntu 18.04).

[1] https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy

On the other hand, this is a one-line patch. Normally when we bump dependencies, we do it because there's some actual strong reason to do so (to use a new API, or due to an incompatible change in the dependency) rather than to avoid one cast. :P I would just accept the patch; it's small and noninvasive and saves us the minor inconvenience of us both having to carry the patch downstream in RHEL and SLED. (I assume I'll need this when I try to update WebKitGTK in RHEL 7; we have ICU 50 there. :)

If we really want to bump our ICU dependency to avoid a cast, then we need to declare it properly in every Options*.cmake that uses find_package(ICU): OptionsAppleWin.cmake, OptionsFTW.cmake, OptionsGTK.cmake, OptionsJSCOnly.cmake, OptionsMac.cmake, OptionsPlayStation.cmake, OptionsWPE.cmake, and OptionsWinCairo.cmake. We currently don't pass any minimum required version there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200401/15cef28a/attachment.htm>