[Webkit-unassigned] [Bug 209805] [GTK] Bring back support for rendering scrollbars using the system appearance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209805

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 395032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395032&action=review
> 
> I've skimmed over the WebCore changes, since they are mostly restoring
> previous code.
> 
> > Source/WebKit/ChangeLog:9
> > +        Add WebKitWebContext:use-system-appearance-for-scrollbars property. It's enabled by default to keep backwards
> > +        compatibility.
> 
> Why? Would an app ever really want to change this setting?

Apps not using other widgets, like web browsers. It's more efficient and would allow to enable threaded rendering (when it's ready). I expect ephy use the setting to disable system appearance.

> For GTK 3, I
> think every app wants to use it, and no apps would want to turn it off. For
> GTK 4, there's no way to make it work, so every app will need to have it
> off.  So I don't think the new property is needed.
> 
> > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:539
> > +     * This is enabled by default for backwards compatibility, but it's only
> > +     * recommened to use when the application includes other widgets to ensure
> > +     * consistency, or when consistency with other applications is required too.
> 
> I can't think of any reason to turn it off...? Isn't consistency with other
> applications always required for GTK? I think so.

Not so important for a web browser, I would say, web sites can use their own scrollbars, so we are used to not being always consistent. The same way we are no longer consistent when rendering buttons or any other controls. Other apps like evolution would look really weird if the emails list uses one scrollbar and the main view a different one.

> > Tools/ChangeLog:8
> > +        Do not use system appearance for scrollbars in MiniBrowser and unit tests.
> 
> Hm, I guess we could find a private way to disable the themed scrollbars for
> layout tests? Something that doesn't require exposing public API?

We are not using any api for layout tests, it's disabled by default, because layout tests don't use the glib api.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200401/fa2fa107/attachment.htm>