[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #12 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #11)
> (In reply to Adrian Perez from comment #10)
> > Actually, I would try and be more fine grained here: if the current
> > value of GtkSettings::theme-name ends in “-dark”, remove the suffix;
> 
> +1, let's do this for now, and close all the dark theme bugs. Themes named
> "midnight" will just stay broken for now.
> 
> In the long term, after removing support for GTK themes, then we can have
> some proper dark mode support. But until then, forcing light is the way to
> go.

I can try to have a patch ready in the next days.

> > in any other case set it to “Adwaita”.
> 
> This must be a typo, because then we'd change "Arc" to "Adwaita" and you
> don't want that.

True, I wrote too fast. Let's try again, this time writing down
things properly:

 * If the theme name is “<name>-dark”:
    - Remove the “-dark” suffix, use “<name>” as the theme.
    - If the theme “<name>” does not exist, GTK automatically
      fall-back to Adwaita.
 * Otherwise:
    - Keep the current theme name, assuming that it is light.

This matches the on-going discussion about the proposal started around
the last GUADEC where dark themes should be required to have a “-dark”
suffix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190926/62f79e4d/attachment.html>