[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #5 from Cassidy James Blaede <cassidy at elementary.io> ---
(In reply to Michael Catanzaro from comment #4)
> We seem to have reached a consensus that we need to remove support for GTK
> themes in order to fix this bug, because the GTK developers are not
> interested in changing GTK to make this solvable. Fixing this bug is more
> important than keeping GTK theme support, and GTK developers don't want us
> using GTK theme on the web anyway. A large number of other dark mode bugs
> will disappear as soon as we remove the GTK support.

That does sound reasonable for a long-term goal, and is in line with what Chrome has done across platforms as far as I can tell.

> But that requires writing a cross-platform theme to replace the GTK theme.
> Safari might be doing this soon too, to get away from macOS platform theme,
> so we will wait and see what happens there.

The one major issue I see with waiting is that the behavior in WebKitGTK changed recently, and is badly breaking websites. See specifically the case where a developer defines a foreground color but not a background color, which is not uncommon: https://cassidyjames.com/dark-demo/mixed.html

A real-world example of this is Startpage.com search results and the GNOME Wiki (https://wiki.gnome.org/Apps/Web). Websites are completely broken with the new dark default stylesheet when using a dark GTK theme. If that's a standalone bug, I am fine to file it, but it's my biggest concern right now with WebKitGTK and will make WebKitGTK unusable for elementary OS in its current state.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190926/37595608/attachment.html>