[Webkit-unassigned] [Bug 202057] Web Inspector: REGRESSION: Elements detail sidebar sometimes starts collapsed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 25 20:33:30 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=202057
--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to Devin Rousso from comment #5)
> Comment on attachment 379275 [details]
> [PATCH] Proposed Fix
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379275&action=review
>
> r=me as is, but I'm also r=me for the below suggestion too :)
>
> > Source/WebInspectorUI/UserInterface/Views/TabContentView.js:55
> > + this._detailsSidebarCollapsedSetting = new WI.Setting(identifier + "-details-sidebar-collapsed", !this.detailsSidebarExpandedByDefault);
>
> Frankly, is there ever a situation where we don't want the sidebar to be
> expanded by default? I think the default collapsed state should just be
> `false`.
Yeah, I think the "Resource" sidebar in the Sources tab would rather not be expanded. The Scope sidebar will auto expand when paused for the first time.
> I do think there's value in allowing the sidebar to be collapsed in certain
> situations (e.g. resource introspection), but I think most of them provide a
> lot of super useful utility (especially when the Sources tab becomes
> default) that we may just want to expand them all by default.
>
> I'm also 100% on board with not allowing the details sidebar from being
> collapsed in the Elements Tab, if we wanted to go that "far".
I think we do, but not just yet. We should get better in narrow configurations.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190926/cc5f3e2e/attachment.html>
More information about the webkit-unassigned
mailing list