[Webkit-unassigned] [Bug 202214] Update API availability for autoplay event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202214

--- Comment #6 from Luming Yin <luming_yin at apple.com> ---
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 379562 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379562&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:213
> > +- (void)_webView:(WKWebView *)webView handleAutoplayEvent:(_WKAutoplayEvent)event withFlags:(_WKAutoplayEventFlags)flags WK_API_AVAILABLE(macos(10.13.4), ios(WK_IOS_TBA));
> 
> It looks like this should be moved into a cross-platform part of the header
> as well.

(In reply to Tim Horton from comment #3)
> Comment on attachment 379562 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379562&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:213
> > +- (void)_webView:(WKWebView *)webView handleAutoplayEvent:(_WKAutoplayEvent)event withFlags:(_WKAutoplayEventFlags)flags WK_API_AVAILABLE(macos(10.13.4), ios(WK_IOS_TBA));
> 
> I think this is in the wrong section? it's in an #else of a #if
> TARGET_OS_IPHONE

Oops, it's indeed in the wrong section! Updated my patch to move it to cross-platform part of the header.

(In reply to Tim Horton from comment #4)
> Comment on attachment 379562 [details]
> Patch
> 
> Also, is there a test for this you can enable on iOS now?

It doesn't seem like there's any test(s) for this API. Are WebKit tests in a separate repository?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190925/7257e47c/attachment-0001.html>