[Webkit-unassigned] [Bug 202052] New: Remove the argument 'resultElement' from the SVG animation functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202052

            Bug ID: 202052
           Summary: Remove the argument 'resultElement' from the SVG
                    animation functions
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: zimmermann at kde.org

This argument was used with the SVG tear-off objects. SVGAnimateElementBase used to have the unique_ptr 'm_animatedType' whose type was SVGAnimatedType. Because this pointer could not be shared, all the contributing SVGAnimateElementBase elements had to use the pointer of the first one which was named resultElement.

Consider the following example:

<svg xmlns="http://www.w3.org/2000/svg">
    <rect width="100" height="100">
        <animate attributeType="XML" attributeName="x" from="0" to="100" dur="3s" begin="0" fill="freeze"/>
        <animate attributeType="XML" attributeName="x" from="100" to="0" dur="3s" begin="3" fill="freeze"/>
    </rect>
</svg>

In this SVG, there are two <animate> elements which animate the same attribute: 'x'. In the SVG tear-off objects world, the first <animate> element was called 'resultElement' because it was creating the pointer 'm_animatedType'. The second, which was called contributor, would access this pointer through the argument 'resultElement'.

After removing the SVG tear-off objects and the type SVGAnimateType, this argument is not used anymore since the SVGAnimatedPropertyAnimator accesses the animVal() of the SVGAnimatedProperty of the SVGElement directly. And this SVGAnimatedProperty can be shared among the other SVGAnimatedPropertyAnimator because the SVGElement store a Ref<SVGAnimatedProperty>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190920/9f9bdcb1/attachment.html>