[Webkit-unassigned] [Bug 202007] New: When reifying a custom accessor, we should consider using CustomGetterSetter instead of GetterSetter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202007

            Bug ID: 202007
           Summary: When reifying a custom accessor, we should consider
                    using CustomGetterSetter instead of GetterSetter
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sbarati at apple.com
                CC: benjamin at webkit.org, fpizlo at apple.com,
                    ggaren at apple.com, gskachkov at gmail.com,
                    guijemont at igalia.com, keith_miller at apple.com,
                    mark.lam at apple.com, msaboff at apple.com,
                    rmorisset at apple.com, ticaiolima at gmail.com,
                    tzagallo at apple.com, ysuzuki at apple.com

I'm not sure why we do it the way we currently do, but it seems bad for perf. Since our ICs already know how to call into custom accessors directly, by caching it as a JS getter/setter with a JSFunction which wraps native code, we're just being circuitous. There's probably a reason why it's currently done this way, perhaps to answer getOwnPropertyDescriptor queries, but we could do better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190919/7ca8b6ed/attachment-0001.html>