[Webkit-unassigned] [Bug 201861] New: Web Inspector: show autocomplete entries for non-index properties on arrays

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201861

            Bug ID: 201861
           Summary: Web Inspector: show autocomplete entries for non-index
                    properties on arrays
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

(In reply to Devin Rousso from https://webkit.org/b/143589#26)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376644&action=review
> 
> >> Source/JavaScriptCore/inspector/InjectedScriptSource.js:-743
> >> -        // For array types with a large length we attempt to skip getOwnPropertyNames and instead just sublist of indexes.
> > 
> > I think `isArrayLike` worked around the fact that `Object.getOwnPropertyNames(o)` for a TypedArray of 1000000 returns a massive array. Hence this comment!
> > 
> > For example:
> > 
> >     console.time();
> >     console.log(Object.getOwnPropertyNames(new Uint8Array(1000000)).length);
> >     console.timeEnd();
> > 
> > Outputs on my very fast iMacPro:
> > 
> >     [Log] 1000000
> >     [Debug] default: 312.283ms
> > 
> > Not to mention the temporary memory spike of a million strings of varying length.
> > 
> > So I think we will still want to keep the isArrayLike path:
> > 
> >    1. For performance
> >    2. To avoid running out of memory
> 
> One kinda "sucky" part of this is that we don't show autocompletion for any custom values on array-like objects.  But given that that's what we have now, I'm inclined to leave this as is and have it as a followup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190917/e38313d1/attachment-0001.html>