[Webkit-unassigned] [Bug 201840] AX: USER: VO: Messages > Message > Shift-VO-M doesn't reveal correct actions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 14:22:01 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=201840
--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 378892
--> https://bugs.webkit.org/attachment.cgi?id=378892
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=378892&action=review
> Source/WebCore/ChangeLog:8
> + menuForEvent: expects event-position in windowâs space, but we pass the position in Coreâs space. In this case, we need to convert coreâs space to windowâs space.
can you use ascii characters here instead of unicode
> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3767
> + ScrollView *scrollView = downcast<AccessibilityScrollView>(*parent).scrollView();
can you change this to
auto scrollView while we're here. should probably also do
// just to ensure we have a scrollView
if (auto scrollView = ...) {
}
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190916/278863dc/attachment.html>
More information about the webkit-unassigned
mailing list