[Webkit-unassigned] [Bug 201645] [GTK] Text areas render wrongly after using backspace or delete key on a blank line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201645

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |koivisto at iki.fi,
                   |                            |zalan at apple.com

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
2ebcc2bac3010714ac6ebbc4397187b5e355d052 is the first bad commit
commit 2ebcc2bac3010714ac6ebbc4397187b5e355d052
Author: antti
Date:   Tue Aug 27 19:29:53 2019 +0000

    InlineTextBox::end() should return first-past-end offset
    https://bugs.webkit.org/show_bug.cgi?id=201181

    Reviewed by Zalan Bujtas.

    It currently points to the last character, except for empty text boxes.
    This is awkward in itself and also inconsistent, as we use first-past-end offset everywhere else.

    * dom/Position.cpp:
    (WebCore::Position::downstream const):

    Add a check for zero length case to avoid changing behavior.

    * layout/Verification.cpp:
    (WebCore::Layout::checkForMatchingTextRuns):
    (WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
    * rendering/InlineFlowBox.cpp:
    (WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
    * rendering/InlineTextBox.cpp:
    (WebCore::InlineTextBox::paint):
    (WebCore::InlineTextBox::calculateDocumentMarkerBounds const):
    (WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
    (WebCore::InlineTextBox::paintCompositionUnderlines const):
    (WebCore::InlineTextBox::paintCompositionUnderline const):
    * rendering/InlineTextBox.h:
    (WebCore::InlineTextBox::end const):

    end = start + len

    * rendering/RenderText.cpp:
    (WebCore::RenderText::setTextWithOffset):
    * rendering/RenderTextLineBoxes.cpp:
    (WebCore::localQuadForTextBox):
    (WebCore::RenderTextLineBoxes::absoluteRectsForRange const):
    (WebCore::RenderTextLineBoxes::absoluteQuadsForRange const):
    (WebCore::RenderTextLineBoxes::dirtyRange):

    Here the incoming 'end' used linebox style too, move that to the new definition too.


    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@249160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

:040000 040000 e110aeb63d19f3d9cf6474087cde263175ea43b6 69079a172fbc33fdabe32f37c9096555324b23dd M      Source

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190916/2c8dad65/attachment.html>