[Webkit-unassigned] [Bug 201340] [GTK][WPE] Do not run the Bubblewrap executable when configuring for cross-compilation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201340

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |aperez at igalia.com
           Assignee|webkit-unassigned at lists.web |aperez at igalia.com
                   |kit.org                     |
            Summary|[GTK][WPE] xdg-dbus-proxy   |[GTK][WPE] Do not run the
                   |is a runtime dep, the check |Bubblewrap executable when
                   |for it in CMake can be      |configuring for
                   |misleading                  |cross-compilation

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
(In reply to Philippe Normand from comment #2)
> Checking for it at build-time doesn't guarantee the runtime host will have
> the program located at the same place though.
> 
> As Adrian pointed out, the CMake stuff should allow for an option specifying
> the absolute path of the program.

I have checked things a bit in this regard. I have both “yay” and
“meh” news:

 - The good news is that it is already possible to override the path
   passing “-DDBUS_PROXY_EXECUTABLE=/path/in/target/xdg-dbus-proxy”
   when invoking CMake—if the variable is set on the command line,
   then find_program() will skip guessing the location of the program.

 - On the other hand, we still need to avoid running programs which
   will be used only at run-time during CMake configuration *when
   cross-compiling*, because a.) they may not be installed in the
   build host, and b.) if they are available in the build host, they
   may not be the same version installed in the target.

The second one is currently an issue because we are currently running
“bwrap --version” from “Source/cmake/BubblewrapSandboxChecks.cmake”
unconditionally. Let's re-purpose this bug for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190914/b542913a/attachment.html>