[Webkit-unassigned] [Bug 201752] Expose misspelling ranges for editable content to accessibility clients.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201752

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 378708
  --> https://bugs.webkit.org/attachment.cgi?id=378708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378708&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:490
> +    // So iterate forward or bakcwars depending on the desired search

backwards

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2658
> +- (NSArray *)misspellingTextMarkerRange:(NSArray *)startTextMarkerRange direction:(NSString *)direction

I feel like we should use a boolean for the direction rather than a string which is not well defined. easier to make a mistake with that kind of parameter. what do you think?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4250
> +        auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second);

we can save a line here by doing

if (auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second))
   return [self textMarkerRangeFromRange:misspellingRange];

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190913/5382f56f/attachment-0001.html>