[Webkit-unassigned] [Bug 105282] Date.prototype.toJSON does not execute steps 1-2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 18:48:46 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=105282

--- Comment #15 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 378688
  --> https://bugs.webkit.org/attachment.cgi?id=378688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378688&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Resolve `this` value using strict mode semantics.
> 
> Can you add a link to the relevant piece of the spec for this change?

nit: Please also describe what the issue is and why the fix works (if not obvious) here in the ChangeLog.  I think the description in https://bugs.webkit.org/show_bug.cgi?id=105282#c0 covers this quite well.  We prefer to make the ChangeLog as descriptive as possible so that if we need to investigate why a change was made, it provides the intent of the author.  Granted, this info may also be present in the bugzilla, but often, the thinking about an issue changes over the period when the issue is being investigated.  Capturing the final understanding on the nature of bug and its fix in the ChangeLog makes it more digestible than having to splunk through the bugzilla comment trail.

Secondly, in my personal experience, when I have to write a descriptive ChangeLog, it forces me to make sure that I really understand what I'm changing, and serves as a sanity check to prevent bugs from creeping in.

So, please add a descriptive ChangeLog, plus a link to the relevant section of the spec for reference.  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190913/0b45997a/attachment-0001.html>


More information about the webkit-unassigned mailing list