[Webkit-unassigned] [Bug 105282] Date.prototype.toJSON does not execute steps 1-2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 17:25:36 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=105282

--- Comment #13 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to Alexey Shvayka from comment #12)
> Thank you for review.
> 
> I took the liberty of tweaking time value finiteness check (step 3 of
> https://tc39.es/ecma262/#sec-date.prototype.tojson).
> While it removes weird isInt32() call, it doesn't justifies making a
> separate patch IMO.

Yeah, that seems fine -- guess it's trying to avoid calling std::isfinite unnecessarily, but that should just amount to `return true` for integral types anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190913/b2509345/attachment.html>


More information about the webkit-unassigned mailing list