[Webkit-unassigned] [Bug 201742] Web Inspector: Tighter autocomplete bubbles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201742

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378684
  --> https://bugs.webkit.org/attachment.cgi?id=378684
[PATCH] Proposed Fix

r=me

> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:123
> +        let intrinsicSize = this._completionLayoutElement.getBoundingClientRect();

We could use `realOffsetWidth`/`realOffsetHeight`, but I like the idea of only fetching `getBoundingClientRect` once.

> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:135
> +        var width = Math.min(containerWidth, maximumWidth);

`let`

> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:136
> +        var paddedWidth = containerWidth;

This isn't needed anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190912/9ca3464a/attachment.html>