[Webkit-unassigned] [Bug 201721] New: Factor out duplicated functions from HTTPParsers.cpp and HTTPHeaderField.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201721

            Bug ID: 201721
           Summary: Factor out duplicated functions from HTTPParsers.cpp
                    and HTTPHeaderField.cpp
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

WebCore/loader/HTTPHeaderField.cpp and WebCore/platform/network/HTTPParsers.cpp
contain functions which duplicate functionality, namely:

  HTTPHeaderField.cpp           HTTPParsers.cpp
  ============================= =====================================
  RFC7230::isCommentText()      isCommentTextCharacter()
  RFC7230::isOBSText()          isOctetInFieldContentCharacter()
  RFC7230::isVisibleCharacter() isVisibleCharacter()
  RFC7230::isDelimiter()        isDelimiterCharacter()
  RFC7230::isTokenCharacter()   isHTTPTokenCharacter()

There are also a couple of functions in HTTPParsers.cpp which could be simplieied
by using helper function from HTTPHeaderField.cpp. For example skipWhiteSpace()
could be written in terms of skipWhile()+RFC3270::isWhitespace(); skipQuotedPair()
could use skipCharacter()+RFC7230::isQuotedPairSecondOctetValue() instead of
duplicating the list of characters that can follow the backslash in a quoted pair,
and so on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190912/e4b30fa9/attachment.html>