[Webkit-unassigned] [Bug 200637] Web Inspector: REGRESSION: Inspector Timeline always starts at about 500ms mark on a reload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200637

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #378616|review?                     |review-
              Flags|                            |

--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 378616
  --> https://bugs.webkit.org/attachment.cgi?id=378616
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378616&action=review

r-, explained below

> Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js:108
> +    get unadjustedStartTime()

The name of this function doesn't seem accurate, or at the very least seems like a roundabout/circumstantial way of getting to the desired result.  The `timestamp` itself isn't guaranteed to be unadjusted either (I know it is right now, but that may not be the case for other future timeline record subclasses).

I think a better approach would be to check `if (record instanceof WI.CPUTimelineRecord || record instanceof WI.MemoryTimelineRecord)` in `_updateTimesIfNeeded` and use the `record.timestamp` in that case instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190912/72404ab7/attachment-0001.html>