[Webkit-unassigned] [Bug 201631] New: [JSC] Manually adding 256 size class to make the current JSC allocation behavior stable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 22:17:06 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=201631

            Bug ID: 201631
           Summary: [JSC] Manually adding 256 size class to make the
                    current JSC allocation behavior stable
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ysuzuki at apple.com

We have old and hacky code like this.

add(sizeof(UnlinkedFunctionCodeBlock));

This manually adds sizeof(UnlinkedFunctionCodeBlock) to size class sequence.
This is really fragile since size-class sequence depends on UnlinkedFunctionCodeBlock size.
The size-class sequence is very fundamental thing for JSC's allocation pattern. And changing this completely changes how JSC allocates.

bug 201613 changed sizeof(UnlinkedFunctionCodeBlock) and dramatically changes the allocation behavior of JSC.
We should make the previous allocation pattern stable.

Instead of adding `add(sizeof(UnlinkedFunctionCodeBlock));`, adding `add(256)` directly to make the previous behavior as baseline.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190910/5d7a97ea/attachment.html>


More information about the webkit-unassigned mailing list