[Webkit-unassigned] [Bug 201536] Test SVGViewSpec behavior across page-loads with different anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 05:13:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=201536

--- Comment #4 from Nikolas Zimmermann <zimmermann at kde.org> ---
(In reply to Rob Buis from comment #3)
Thanks Rob!

> > LayoutTests/svg/dom/SVGViewSpec-multiple-views.html:23
> > +    document.body.appendChild(script);
> 
> Why is the js-test-post.js script added dynamically at the end? Could it not
> be declared right after js-test-pre.js?
Indeed, there is a 'jsTestIsAsync' mode that I can use.
But still it cannot be loaded right after js-test-pre.js, because I need a chance to say "jsTestIsAsync = true", which is typically done after the description() call, when comparing to other tests.

But I should be able to get rid of the custom completeJSTest() method: avoiding boilerplate is nice, so I will try that.

> 
> > LayoutTests/svg/dom/SVGViewSpec-multiple-views.html:173
> > +iframeElement.setAttribute("style", "display: block");
> 
> Is this needed?

I will see how it looks in MiniBrowser w/o that. For the actual test result, it makes no difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190909/6c2a736c/attachment.html>


More information about the webkit-unassigned mailing list