[Webkit-unassigned] [Bug 201594] New: [FTW] ImageBuffer/ImageBufferData is highly inefficient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 8 16:03:53 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=201594

            Bug ID: 201594
           Summary: [FTW] ImageBuffer/ImageBufferData is highly
                    inefficient
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

My initial implementation of ImageBuffer and ImageBufferData for Direct2D involves too much moving of data from GPU to CPU and back. We only need to make a renderable version of the ImageBuffer when ImageBuffer::sinkIntoNativeImage or ImageBuffer::copyNativeImage are called.

Currently, each ImageBuffer putData operation uploads the data to the GPU, and each ImageBuffer getData pulls the data from the GPU.

This patch does the following:

1. It makes the assumption that the ID2D1Bitmap it holds is under its control (i.e., external draw operations do not manipulate the bitmap without marking it dirty).
2. It holds a CPU copy of the data from the ID2D1Bitmap originally used to create it. It uses this data for all manipulations, and uploads to the bitmap only when
   an ID2D1Bitmap is requested for drawing.
3. It does not read back from the ID2D1Bitmap unless it is told that it is dirty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190908/704bde1f/attachment.html>


More information about the webkit-unassigned mailing list