[Webkit-unassigned] [Bug 201487] Generate event region for both the main graphics layer and the scrolled contents layer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 5 09:46:40 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=201487
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 378041 [details]
> patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378041&action=review
>
> Are there behavioral changes from using RenderLayerBacking::paintIntoLayer()
> now that can be tested?
>
> > Source/WebCore/rendering/RenderLayerBacking.cpp:1601
> > + auto clipRect = enclosingIntRect(compositedBounds());
>
> Isn't this wrong for the scrolled contents? You need to expand the clip
> there.
Fixed this to provide the layer size as the dirty rect (it worked before in common cases because the dirty rect is mostly ignored).
> An issue with generating the event region for the entire scrolled contents
> is that you're potentially traversing a massive render tree, most of which
> is not visible. Ideally we'd generate event regions for areas with live
> tiles only.
On the other hand we won't need to update the event region during scrolling if we generate it all at once (separate invalidation bit will enable that).
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190905/065f1c93/attachment.html>
More information about the webkit-unassigned
mailing list