[Webkit-unassigned] [Bug 187460] ResourceResponseBase wastes a lot of space because of std::optional<>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187460

--- Comment #52 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Daniel Bates from comment #49)
> Patches seems absolutely in the wrong direction we want in this project in
> my opinion. In my opinion the project wants to use enum classes (not enum)
> and in my opinion we don't want enumerators like SourceNetwork
> <--concatenating the concept and value.

Yeah, it's not like we can't cast unsigned to enum class either. Packing objects better matter in many cases but here, we don't need to resort to bitfields at all since three uint8_t + one uint32_t would pack neatly into a single uint64_t space.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190905/d00b0f27/attachment.html>