[Webkit-unassigned] [Bug 187460] ResourceResponseBase wastes a lot of space because of std::optional<>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 5 01:03:48 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=187460

--- Comment #50 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373194
  --> https://bugs.webkit.org/attachment.cgi?id=373194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373194&action=review

> Source/WebCore/platform/network/ResourceResponseBase.h:234
> +protected:
> +    int m_httpStatusCode { 0 };
> +
> +private:
> +    mutable bool m_includesCertificateInfo : 1;

This is a really shitty way of packing stuff.
Move m_httpStatusCode past all these boolean bitfields, and they would pack a lot better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190905/0bddc957/attachment.html>


More information about the webkit-unassigned mailing list