[Webkit-unassigned] [Bug 199292] JSON.parse incorrectly handles array proxies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199292

--- Comment #8 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Saam Barati from comment #6)
> Comment on attachment 376429 [details]
> Patch
> 
> nice. Can you verify this doesn't make JSON parsing slower?

Please note that changes in Walker::walk may affect only JSON.parse with custom reviver (2nd argument).
I've added two sets of microbenchmarks: reviver returning same or different value.
We will find them useful in https://bugs.webkit.org/show_bug.cgi?id=163446 as well.

Cold runs, --outer 16:

                                            rev. 249368              patch

json-parse-object-reviver-same-value      196.5163+-1.1350      198.7460+-1.4635
json-parse-array-reviver-same-value       143.3628+-1.1241      150.7418+-1.2160
json-parse-object-reviver                 217.9791+-1.2748      223.2554+-1.9196
json-parse-array-reviver                  197.3965+-3.8484      198.1227+-1.9369

<geometric>                               186.5654+-1.0157      190.7782+-0.8042

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190902/50e92eca/attachment-0001.html>