[Webkit-unassigned] [Bug 203408] Create base class common to AccessibilityObject and AXIsolatedTreeNode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203408

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rniwa at webkit.org

--- Comment #18 from Ryosuke Niwa <rniwa at webkit.org> ---
This patch appears to have broken Windows builds:
e.g.

https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/7858/steps/compile-webkit/logs/stdio

  JSInternals.cpp
c:\cygwin\home\buildbot\worker\win10-debug\build\source\webkitlegacy\win\accessiblebase.cpp(361): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebKitLegacy\WebKitLegacy.vcxproj]
c:\cygwin\home\buildbot\worker\win10-debug\build\source\webkitlegacy\win\accessiblebase.cpp(361): warning C4541: 'dynamic_cast' used on polymorphic type 'WebCore::AXCoreObject' with /GR-; unpredictable behavior may result [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebKitLegacy\WebKitLegacy.vcxproj]
c:\cygwin\home\buildbot\worker\win10-debug\build\source\webkitlegacy\win\accessiblebase.cpp(1048): warning C4541: 'dynamic_cast' used on polymorphic type 'WebCore::AXCoreObject' with /GR-; unpredictable behavior may result [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebKitLegacy\WebKitLegacy.vcxproj]
  WebDesktopNotificationsDelegate.cpp

We disable RTTI so I'm not certain dynamic_cast even works in WebKit...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191031/7be63396/attachment-0001.htm>