[Webkit-unassigned] [Bug 203642] covscan: Incorrect check in RenderBox::hasOverrideContainingBlockContentHeight

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203642

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 382388
  --> https://bugs.webkit.org/attachment.cgi?id=382388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382388&action=review

> Source/WebCore/ChangeLog:11
> +        Checking HeightMap twice is definitely wrong.
> +        Given that hasOverrideContainingBlockContentHeight() should
> +        do the opposite of hasOverrideContainingBlockContentWidth() and
> +        correspond with overrideContainingBlockContentHeight(), do so.

Since this is a bug fix, it should come with a regression test that fails before the fix, and passes after the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191031/60dcae0f/attachment.htm>