[Webkit-unassigned] [Bug 203389] New: Unused arguments in MESSAGE_CHECK_CONTEXTID() macros

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 16:26:04 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=203389

            Bug ID: 203389
           Summary: Unused arguments in MESSAGE_CHECK_CONTEXTID() macros
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org

Unused arguments in MESSAGE_CHECK_CONTEXTID() macros due to typos (`contextID` vs. `contextId`):

PlaybackSessionManagerProxy.mm
        #define MESSAGE_CHECK_CONTEXTID(contextID) MESSAGE_CHECK_BASE(m_contextMap.isValidKey(contextId), m_page->process().connection())

VideoFullscreenManagerProxy.mm
        #define MESSAGE_CHECK_CONTEXTID(contextID) MESSAGE_CHECK_BASE(m_contextMap.isValidKey(contextId), m_page->process().connection())

This one is okay (uses `id` in both places):

UserMediaCaptureManagerProxy.cpp
        #define MESSAGE_CHECK_CONTEXTID(id) MESSAGE_CHECK_BASE(m_proxies.isValidKey(id), m_process.connection())

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191024/bad08c9c/attachment-0001.htm>


More information about the webkit-unassigned mailing list