[Webkit-unassigned] [Bug 203252] Move MatchResult and related types out of StyleResolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203252

--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
> This function can be added to MatchResult. ]

I actually had that but it requires some further refactoring (moving CascadeLevel enum). I decided I need to stop at some point.

> 
> > Source/WebCore/css/StyleResolver.h:421
> > +        Vector<MatchedProperties> userAgentDeclarations;
> > +        Vector<MatchedProperties> userDeclarations;
> > +        Vector<MatchedProperties> authorDeclarations;
> 
> Can't we replace these member by just one MatchResult?  I think all what we
> do with these members is assigning their values from a MatchResult and
> comparing them with a MatchResult.

Almost, the issue is that MatchResult has large inline capacity for these (it is a temporary type used during collection) while cache entries have none (they are long-lived and immutable).

Making that work requires either templating MatchResult or proving that inline capacity is unnecessary (it probably is) which is best left for another patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191024/229fac17/attachment-0001.htm>