[Webkit-unassigned] [Bug 202847] [GTK][WPE] Add user messages API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 06:50:32 PDT 2019


--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #15) 
> I don't know who corrected me recently changing web to Web somewhere, anyway
> let's be consistent in our docs, I'll change it.

That was Adrian... we had a little argument about that afterwards. I hope I've successfully argued my case for lowercase web. :P

> > > Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:299
> > > +    GRefPtr<WebKitUserMessage> adoptedReply = reply;
> > 
> > Probably a good idea to add your one-line comment about sinking the message
> > here, since you did everywhere else, and it's not obvious.
> Didn't add it in this case because I thought the adopted prefix in the name
> was self-explanatory. I'll add the comment in any case, it won't hurt.

I didn't notice, but that arguably makes it even worse because people might assume from the variable name that you forgot to adopt the ref.

> You are good catching my typos :-D

I think you use copy/paste more than I do. It's easy to make a typo once, when declaring or calling a function, but it's rare that I make the same typo in both places. So normally the compiler yells when I mess up. But if you use Ctrl+V to paste the function name, typos can go unnoticed.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191015/6a3429b6/attachment.html>

More information about the webkit-unassigned mailing list