[Webkit-unassigned] [Bug 202847] [GTK][WPE] Add user messages API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202847

--- Comment #14 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 380972
  --> https://bugs.webkit.org/attachment.cgi?id=380972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380972&action=review

LGTM. I'll leave r+ for Adrian, though.

> Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:46
> + * and Web extensions. A WebKitUserMessage always have a name, and it can also include parameters and

We've never capitalized web before, at least not in web process or web extension. I wouldn't start now.

Also: have -> has

> Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:49
> + * corresponding #WebKitWebPage (and vice versa). One to one messages can be replied directly with

"replied to"

> Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:299
> +    GRefPtr<WebKitUserMessage> adoptedReply = reply;

Probably a good idea to add your one-line comment about sinking the message here, since you did everywhere else, and it's not obvious.

> Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp:46
> +bool decode(Decoder& decoder, GRefPtr<GVariant>& variant)

Shouldn't it return Optional<GRefPtr<GVariant>&>, using Optional return instead of an out parameter, as you did for the UserMessage class? I think this is an old-style decoder that we're supposed to be moving away from, when you used the modern style in UserMessage.

> Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebExtension.cpp:162
> +     * replied. Calling webkit_user_message_send_reply() will do nothing.

replied to.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:586
> +    void sendMedssageToAllExtensions(WebKitUserMessage* message)

Medssage -> Message

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:641
> +static bool readFileDescritpor(int fd, char** contents, gsize* length)

Descritpor -> Descriptor

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191015/87ae7837/attachment-0001.html>