[Webkit-unassigned] [Bug 202847] [GTK][WPE] Add user messages API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202847

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #8)
> Comment on attachment 380746 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380746&action=review
> 
> >> Source/WebKit/Shared/API/glib/WebKitUserMessage.cpp:162
> >> +     * after the message has been sent.
> > 
> > Maybe we want to explicitly have a note indicating that...
> > 
> >   “If the sender needs to keep the file descriptor, `dup(2)`
> >    can be used to send a new descriptor referring to the same
> >    data.”
> > 
> > I suggest this because my first thought was “what if I need to keep
> > referring to some shared data in both processes” and it took me a
> > minute to realize how to do it. Maybe for many people it's obvious,
> > but it won't hurt pointing it out, I think.
> 
> Or we could always dup and avoid confusions. I decided to steal mainly
> because I think of WebKitUserMessage as a temp object (that's also why it's
> initially unowned), that you don't care about after being sent.

I've realized that we should always dup, otherwise it would be impossible to send a message with fds using webkit_web_context_send_message_to_all_extensions(). I'll update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191014/871f171f/attachment.html>