[Webkit-unassigned] [Bug 202719] [CSS Shadow Parts] Allow exporting single part with multiple names using exportparts attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 9 00:28:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=202719

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #380502|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 380502
  --> https://bugs.webkit.org/attachment.cgi?id=380502
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380502&action=review

> Source/WebCore/css/SelectorChecker.cpp:1181
> +            for (unsigned i = 0; i < element.partNames().size(); ++i)

We can’t use range loop?

> Source/WebCore/dom/ShadowRoot.h:99
> +    using PartMappings = HashMap<AtomString, Vector<AtomString, 1>>;

Should we typedef Vector?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191009/2ebe6687/attachment.html>


More information about the webkit-unassigned mailing list