[Webkit-unassigned] [Bug 202545] Fix WebGL 1 conformance regressions when USE_ANGLE=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202545

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 380163
  --> https://bugs.webkit.org/attachment.cgi?id=380163
Fix WebGL 1 conformance regressions when USE_ANGLE=1

View in context: https://bugs.webkit.org/attachment.cgi?id=380163&action=review

> Source/WebCore/html/canvas/WebGLDebugShaders.cpp:54
>      if (m_context.isContextLost())
>          return String();

Since this function can no longer return null, it doesn’t make sense to return a null string here. Before the change to the bindings, this would turn into a JavaScript null, so this line of code may have had a valuable effect. We should consider returning an empty string here. Or perhaps removing this code entirely as long as the validateWebGLObject function is guaranteed to return false when the context is lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191008/280a08b8/attachment.html>