[Webkit-unassigned] [Bug 199705] Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199705

--- Comment #24 from mitz at webkit.org ---
(In reply to Alexey Proskuryakov from comment #23)
> What style checker is saying is that we should add a HAVE macro for these
> SDKs in Platform.h. But looking at the patch, there is already
> HAVE(SUBVIEWS_IVAR_SPI). Isn’t it just defined improperly?

HAVE_SUBVIEWS_IVAR_SPI is defined properly. The SPI is available when deploying to macOS 10.15 or later. When deploying to earlier macOS, the SPI is not available and there is code in WebHTMLView.mm implementing an alternative, but that implementation depends on an ivar declaration. The ivar declaration is not present in the macOS 10.15 and later SDKs. Thus the condition for declaring the ivar in the SPI header is the one stated in the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191007/29c8b593/attachment-0001.html>