[Webkit-unassigned] [Bug 199705] Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199705

--- Comment #22 from mitz at webkit.org ---
(In reply to Maciej Stachowiak from comment #21)
> The wincairo and wk1 failures appear unrelated. 
> 
> The style checker issue is about having an OS version check here, correctly
> suggesting it should go in a named macro. I'd do this myself, but I'm not
> sure what the purpose of the `__MAC_OS_X_VERSION_MAX_ALLOWED >= 101500`
> clause is.

This makes the ivar declaration only when using the macOS Catalina or later SDK, because earlier SDKs include the declaration, and redeclaring an ivar is an error. I am not aware of WTF macros that express this (since conditionals based on SDK version are so uncommon).

> For folks in this configuration who are having trouble building, could you
> please report whether the patch solves your problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191006/682fe3da/attachment.html>