[Webkit-unassigned] [Bug 199705] Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199705

--- Comment #19 from Kenneth Russell <kbr at google.com> ---
(In reply to mitz from comment #18)
> (In reply to Kenneth Russell from comment #17)
> > Ran into this problem too after updating to Xcode 11 on 10.4.6 in order to
> > pick up the iOS 13 SDK, which seemed required to build for the iOS
> > Simulator. This presents a chicken-and-egg problem since it's not possible
> > to build for the iOS Simulator without Xcode 11, but not possible to build
> > for macOS with it.
> > 
> > I was able to work around this by adding the following hack to
> > WebHTMLView.mm:
> > 
> > diff --git a/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
> > b/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
> > index 347826af20a..448d4c714d9 100644
> > --- a/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
> > +++ b/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
> > @@ -217,6 +217,8 @@
> >  #if !HAVE(SUBVIEWS_IVAR_SPI)
> >  @implementation NSView (SubviewsIvar)
> >  
> > +NSMutableArray<__kindof NSView *> *_subviews;
> > +
> 
> That’s not correct. It defines a global variable unrelated to the class.
> Declaring the ivar in a class extension, on the other hand, should work.

I know it's not correct. As I mentioned I don't know enough Objective-C to write a correct fix - any chance you could put up a patch implementing that? I'll be happy to help test it. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191006/bbfb5db2/attachment.html>