[Webkit-unassigned] [Bug 201775] FindController::findString always updates foundStringMatchIndex even if match is the same as before

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201775

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 380265
  --> https://bugs.webkit.org/attachment.cgi?id=380265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380265&action=review

> Source/WebCore/ChangeLog:10
> +            Add NoIndexChange find option flag

No indentation

> Source/WebKit/ChangeLog:22
> +            Do not change match index if NoIndexChange bit is set. Otherwise, no change in behavior.

This is indented wrong

> Source/WebKit/Shared/WebFindOptions.h:39
> +    FindOptionsNoIndexChange = 1 << 8,

It's not a problem in this case, but a bit odd to add to the middle of an enum.

> Source/WebKit/WebProcess/WebPage/FindController.cpp:70
> +    if (options & FindOptionsNoIndexChange)
> +        result.add(WebCore::NoIndexChange);

You can avoid the WebCore change and the core() change; nothing ever uses this option in WebCore, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191004/dbf13eba/attachment-0001.html>