[Webkit-unassigned] [Bug 202551] [GTK] Crash in WebChromeClient::createDisplayRefreshMonitor
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 4 03:38:30 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=202551
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 380206
--> https://bugs.webkit.org/attachment.cgi?id=380206
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=380206&action=review
>> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:71
>> + ASSERT(!m_rootLayer);
>
> Where does this get nulled out now, in a way that it would make the assertion succeed?
In invalidate().
>> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:213
>> + if (!m_rootLayer && !isFlushingLayerChanges())
>
> wouldn't this be if (m_rootLayer && !isFlushingLayerChanges())? As the should only notify if the root layer is still alive.
Oops, indeed, good catch!
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191004/755c86d4/attachment.html>
More information about the webkit-unassigned
mailing list