[Webkit-unassigned] [Bug 202487] New: Web Inspector: remove `InspectorInstrumentationCookie`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 2 12:34:08 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=202487

            Bug ID: 202487
           Summary: Web Inspector: remove `InspectorInstrumentationCookie`
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

All it does is create a shallow-copy of the `InstrumentingAgents` (it copies a pointer to the `InstrumentingAgents` object, so any of the pointers to the `InspectorAgent` that are contained therein are shared between each instance) and save the tracking `InspectorTimelineAgent`'s id (monotonically increasing integer).  All uses of `InspectorInstrumentationCookie` are local values, so there's no way that the `InspectorTimelineAgent` (or the id) could change in between an `InspectorInstrumentation::will*` and an `InspectorInstrumentation::did*`, as both the tracking state and id are controlled by the frontend and cannot "interrupt".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191002/e3c7367d/attachment.html>


More information about the webkit-unassigned mailing list