[Webkit-unassigned] [Bug 202447] [GTK] Don't hardcode swipe navigation gesture style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 2 06:06:25 PDT 2019


--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 380009
  --> https://bugs.webkit.org/attachment.cgi?id=380009

View in context: https://bugs.webkit.org/attachment.cgi?id=380009&action=review

LGTM, why didn't you ask for review this time?

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1450
> +#if GTK_CHECK_VERSION(3, 20, 0)
> +    gtk_widget_class_set_css_name(widgetClass, "webkitwebview");
> +#endif

What happens when building with previous gtk?

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:31
> +#include "WebCore/GRefPtrGtk.h"

Use <WebCore/GRefPtrGtk.h>

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:301
> +static cairo_pattern_t* createElementPattern(GRefPtr<GtkStyleContext> context, int width, int height)

Sorry, I meant using the raw pointer for the context parameter instead of copying the GRefPtr, the smart pointer was ok for the return value.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191002/0ec535a0/attachment.html>

More information about the webkit-unassigned mailing list