[Webkit-unassigned] [Bug 204629] Remove own toString from NativeError prototype

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204629

--- Comment #14 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 384526
  --> https://bugs.webkit.org/attachment.cgi?id=384526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384526&action=review

r=me, though you'll need to regenerate the ChangeLogs.

> JSTests/stress/nativeerror-prototype-tostring.js:7
> +  if (NativeError.prototype.hasOwnProperty('toString')) {
> +    throw new Error(`${NativeError.name}.prototype should not have own property 'toString'`);
> +  }

Nit: WK style drops braces for one-line conditionals (https://webkit.org/code-style-guidelines/#braces-one-line).
I guess the checker ignores JS stress tests but we ought to align anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191129/f24e35a3/attachment.htm>