[Webkit-unassigned] [Bug 204669] New: [GStreamer] Simplify GL display/context ref handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204669

            Bug ID: 204669
           Summary: [GStreamer] Simplify GL display/context ref handling
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pnormand at igalia.com
                CC: annulen at yandex.ru, calvaris at igalia.com,
                    cgarcia at igalia.com, eric.carlson at apple.com,
                    ews at webkit.org, glenn at skynav.com, gns at gnome.org,
                    gyuyoung.kim at webkit.org, jbedard at apple.com,
                    jer.noble at apple.com, menard at kde.org,
                    philipj at opera.com, ryuan.choi at navercorp.com,
                    sergio at correia.cc, vjaquez at igalia.com
        Depends on: 204624

+++ This bug was initially created as a clone of Bug #204624 +++


> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:151
> +    // The floating ref removal support was added in https://bugzilla.gnome.org/show_bug.cgi?id=743062.
> +    bool shouldAdoptRef = webkitGstCheckVersion(1, 14, 0);


I think we could simplify the code by adding adoptGLRef() or something like that, similar to ensureGRef, that only accepts GstGLDisplay org GstGLContext and adopts the returned ref or not depending on the GST version.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=204624
[Bug 204624] [GStreamer] Move GL video sink to its own GstBin sub-class
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191128/4f019d35/attachment-0001.htm>