[Webkit-unassigned] [Bug 204613] [LFC][Render tree] Add LFC line layout path to RenderBlockFlow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204613

--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 384348
  --> https://bugs.webkit.org/attachment.cgi?id=384348
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384348&action=review

> Source/WebCore/layout/RenderBlockFlowLineLayout.cpp:91
> +LayoutUnit RenderBlockFlowLineLayout::height() const

Since there are many different types of box height, I think it would be great if this function was named contentBoxHeight() (as opposed to padding/border/margin box height).

> Source/WebCore/layout/invalidation/InvalidationState.cpp:47
> +    if (layoutBox.isInitialContainingBlock()) {
> +        m_formattingContextRoots.add(downcast<Container>(layoutBox));
> +        return;
> +    }

As the comment/assert implies here the ICB should never need an update. It has to have a pre-computed geometry (in full LFC mode, it's always the view size, in partial LFC mode, I guess it's the flow's content box size). It's only the children that need update (layout).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191126/05553b49/attachment.htm>