[Webkit-unassigned] [Bug 203460] REGRESSION(2.27.2): [GTK] Incognito mode is broken under flatpak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203460

--- Comment #37 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #33)
> Comment on attachment 384281 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384281&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        REGRESSION(2.27.2): [GTK] Incognito mode is broken under flatpak
> 
> Does it really have anything to do with flatpak?

It can only be reproducible under flatpak. It seems that g_mkdir_with_parents("/Version 14", S_IRWXU) doesn't return -1 under flatpak for some reason. I agree it's much better the explicit early return than waiting until makeAllDirectories fails, though.

> > Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:75
> > +#if PLATFORM(GTK) || PLATFORM(WPE)
> > +    // This can only happen when the main WebsiteDataStore is ephemeral. Since the network process always creates a default
> > +    // non-ephemeral session, this is called with the cache path of the WebsiteDataStore that is nullptr (we don't want any
> > +    // disk write in ephemeral contexts).
> > +    if (cachePath.isNull())
> > +        return nullptr;
> > +#else
> > +    ASSERT(!cachePath.isNull());
> > +#endif
> 
> FWIW this comment seems like a good justification to avoid the #ifdefs and
> use the early return on all ports. But Youenn's decision.
> 
> LGTM.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191126/54c73e0e/attachment-0001.htm>