[Webkit-unassigned] [Bug 203288] MediaQueryList should extend EventTarget

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203288

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org
 Attachment #384151|review?                     |review-
              Flags|                            |

--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 384151
  --> https://bugs.webkit.org/attachment.cgi?id=384151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384151&action=review

> Source/WebCore/css/MediaQueryList.cpp:60
> +    addEventListener("change", listener.releaseNonNull());

The IDL declares the listener parameter as optional, so I don't think you can remove the null check if you are going to keep this listener.releaseNonNull(). Same with removeListener below.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191126/0aa635e3/attachment-0001.htm>