[Webkit-unassigned] [Bug 203460] REGRESSION(2.27.2): [GTK] Incognito mode is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203460

--- Comment #31 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 383735
  --> https://bugs.webkit.org/attachment.cgi?id=383735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383735&action=review

>>> Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:68
>>> +        return nullptr;
>> 
>> I would think this check is not needed.
>> Cache::open should only be called if sessionID.isEphemeral() is not true, hence cachePath not being null.
>> Is it possible that GTK port is using 'ephemeral' sessions with sessionID.isEphemeral() being false?
> 
> The network process always creates a default non ephemeral session in NetworkProcess::initializeNetworkProcess().

Let's make it GTK specific for now and add an ASSERT(!cachePath.isNull()) for other ports.
If other ports are like GTK, let's make the ASSERT COCOA specific.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191122/b9e21262/attachment-0001.htm>