[Webkit-unassigned] [Bug 203460] REGRESSION(2.27.2): [GTK] Incognito mode is broken

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 09:05:23 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=203460

--- Comment #30 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Actually I think I'm wrong. I misunderstood Carlos's comment. WebKitWebsiteDataManager.cpp creates ephemeral WebsiteDataStore using WebsiteDataStore::createNonPersistent, which uses generateEphemeralSessionID. So I guess it's fine. We could still have various problems caused by overuse defaultSessionID(), of course.

(In reply to Carlos Garcia Campos from comment #25)
> The network process always creates a default non ephemeral session in
> NetworkProcess::initializeNetworkProcess().

I understand it's always created, but just not going to be used in ephemeral mode. So then this change makes sense to me as-is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191122/7d959f2e/attachment.htm>


More information about the webkit-unassigned mailing list